longturn / freeciv21

Develop your civilization from humble roots to a global empire
GNU General Public License v3.0
221 stars 42 forks source link

Connecting to square games gives hex tiles #2441

Open lmoureaux opened 3 hours ago

lmoureaux commented 3 hours ago

Describe the bug Connecting to a game using square tiles may load a hex tileset

To Reproduce Steps to reproduce the behavior:

  1. Move your config folder
  2. Start the game
  3. Connect to a running game with isometric square tiles
  4. hexemplio is used

Expected behavior amplio2 is used

Platform and version (please complete the following information):

Additional context Reported by Blauwal on Discord after updating his snap to 3.1-rc1, confirmed locally.

lmoureaux commented 3 hours ago

Produced config:

default_tileset_square_name=""
default_tileset_hex_name=""
default_tileset_isohex_name=""
lmoureaux commented 3 hours ago

The issue is that fill_topo_ts_default doesn't actually fill tileset options and we end up with hexemplio loaded.