search

longxinH / xhprof

PHP7/PHP8 support
http://pecl.php.net/package/xhprof
Apache License 2.0
1.09k stars 167 forks source link

Composer support added #28

Closed drIceman closed 4 years ago

rez1dent3 commented 5 years ago

@longxinH I think you should not accept this pull request. Too much will have to be pulled through composer.

drIceman commented 5 years ago

@rez1dent3 If you reject, then you offer.

rez1dent3 commented 5 years ago

@drIceman There is no good idea, but dragging the source in vendor is bad. It seems to me there is no problem in resolving it locally

rez1dent3 commented 5 years ago

@drIceman Another option is to put php in a separate project so as not to drag the xhprof sources

drIceman commented 5 years ago

I want to do like this https://chromabits.com/posts/2016/02/10/laravel-xhprof/

But only for PHP7.

And I don’t want to set up my repository everywhere, in each of microservices, containers and etc.

This requires the vendor to have composer support.

longxinH commented 5 years ago

@drIceman It is not recommended to use composer. When multiple nodes are used, you can use the form of escalation to display through the center service.