We add the required config.w32, and also use some POSIX compatibility
includes from PHP. Furthermore, we use QueryPerformanceCounter() on
Windows, and optimize the use of QueryPerformanceFrequency() by
calling it once on MINIT, and storing the result in a true global
variable.
This is just the most basic Windows support. With the patch, xhprof compiles for me locally with PHP 7.3 x64 NTS, but I still have three failing tests; two of them fail due to stack corruption, likely caused by variables being declared as long which are usually 8 bytes on *nix, but 4 bytes on Windows. It's probably better to use more portable types, such as zend_long or int64_t.
longxinH
commented
4 years ago
We add the required config.w32, and also use some POSIX compatibility includes from PHP. Furthermore, we use
QueryPerformanceCounter()on Windows, and optimize the use ofQueryPerformanceFrequency()by calling it once on MINIT, and storing the result in a true global variable.This is just the most basic Windows support. With the patch, xhprof compiles for me locally with PHP 7.3 x64 NTS, but I still have three failing tests; two of them fail due to stack corruption, likely caused by variables being declared as
longwhich are usually 8 bytes on *nix, but 4 bytes on Windows. It's probably better to use more portable types, such aszend_longorint64_t.