search

longxinH / xhprof

PHP7/PHP8 support
http://pecl.php.net/package/xhprof
Apache License 2.0
1.04k stars 165 forks source link

Use consitent URL generation #54

Closed andypost closed 3 years ago

andypost commented 3 years ago

This approach allow to have any script name to view runs, all internal links now using common script name.

The cause is that list_runs generates the link properly https://github.com/longxinH/xhprof/blob/adcf344775b9dd778cf6c2e0f94990f4ca3ad29f/xhprof_lib/utils/xhprof_runs.php#L155

But other places for callgraph.php is only consumers for the global var so I just added new one to provide 

xhprof_lib/display/xhprof.php:880:                    "$base_path/callgraph.php" . "?" . http_build_query($url_params))
xhprof_lib/display/xhprof.php:1148:  $callgraph_href = "$base_path/callgraph.php?"