search

longzuyuan / ics-openvpn

Automatically exported from code.google.com/p/ics-openvpn
0 stars 0 forks source link

comp-lzo imported wrong #56

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
My config has:

comp-lzo no

Yes after import comp-lzo is enabled.

Original issue reported on code.google.com by ni...@peen.net on 10 Jul 2012 at 12:07

GoogleCodeExporter commented 9 years ago 
Yes. This is by design. My gui does not have the choise comp-lzo no in order 
not to confuse users. comp-lzo no and no comp-lzo are different things. 
comp-lzo no allows the server to "push comp-lzo [yes]"  to enable lzo. If a 
config has a comp-lzo I import it always as comp-lzo adaptive. The server can 
always override the comp-lzo settings

Original comment by arne@rfc2549.org on 10 Jul 2012 at 4:54

GoogleCodeExporter commented 9 years ago 
That's the way it was with older OpenVPN version. Unfortunately this is no 
longer the case.

Original comment by ni...@peen.net on 10 Jul 2012 at 4:56

GoogleCodeExporter commented 9 years ago 
I have just tested it. Importing a comp-lzo no config worked. Can you point to 
any document which has that this behaviour has changed?

Original comment by arne@rfc2549.org on 10 Jul 2012 at 5:00

GoogleCodeExporter commented 9 years ago 
Importing doesn't throw any erros, but the line is lost, right?

I haven't found any documentation on it, but had to figure this out by trial 
and error. However I've pointed out the same issue to authors of OpenVPN 
clients for Windows and Mac whom confirmed the findings and adjusted their 
clients accordingly.

Original comment by ni...@peen.net on 10 Jul 2012 at 5:05

GoogleCodeExporter commented 9 years ago 
The line is not lost but converted to comp-lzo yes. If you have no comp-lzo 
line then no comp-lzo is added to the config.

I will try to find a testcase where current import logic does not work. (Aside 
from the cornercase of a server configured with comp-lzo no and compiled with 
stub-lzo)

Original comment by arne@rfc2549.org on 10 Jul 2012 at 5:21

GoogleCodeExporter commented 9 years ago 
I have tried various comp-lzo yes/no/adaptive combinations on client and server 
and all worked fine. I can't reproduce the problem, sorry :/

Original comment by arne@rfc2549.org on 15 Jul 2012 at 11:29

GoogleCodeExporter commented 9 years ago 
Talking with the developers of OpenVPN confirmed my opinion of how comp-lzo 
works. 

For reference if you really need comp-lzo no you can still deselect lzo 
compression and add comp-lzo no as an advanced option

Original comment by arne@rfc2549.org on 19 Jul 2012 at 8:49