longzuyuan / ics-openvpn

Automatically exported from code.google.com/p/ics-openvpn
0 stars 0 forks source link

Different notification icons/blinking notification/buggy notification while connecting #75

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Connect any vpn
2. Slide down notification bar

What is the expected output? What do you see instead?
There are two notifications, both obviously created by openvpn,
with different icons http://db.tt/RwXu8JhE. I'd expect them to have a similar 
look. Google (and me ^^) want notification icons to be white I think, so why 
don't go with the system theme and make it look similar to this 
http://db.tt/eGjXfFzn.

Second issue: When the notification displaying current throughput and up/down 
amount is refreshed, it's not visible for about 200ms and reappears with 
updated stats. This happens every 2 to 7 seconds.

Third issue: While a connection is being established, a notification should 
display current status, but it's not displayed correctly http://db.tt/BGburG89, 
http://db.tt/rRKj9rt7 (GET_CONFIG looks similar, but I was to slow to get a 
screen..)

What mobile phone are you using?
Samsung Nexus S i9023

Which Android Version and stock ROM or aftermarket like cyanogenmod?
Android 4.1.1, stock, rooted.

Please provide any additional information below.
If internet access happens always through openvpn, two always-on notifications 
take too much space. An option to turn the notification displaying the network 
stats off would be an elegant solution imho.

Original issue reported on code.google.com by 7amp...@gmail.com on 25 Aug 2012 at 10:56

GoogleCodeExporter commented 9 years ago
1. Yes. The colorful notification icon is done android itself and uses the 
application icon. I did not see a way to change which icon android uses for the 
notification.

2. I look into that. I don't know if the notification can be replaced without 
causing the refreshing effect.

3. What exactly is wrong with the notification? Are you critising the commas?

Original comment by arne@rfc2549.org on 25 Aug 2012 at 6:16

GoogleCodeExporter commented 9 years ago
About #3, yes mainly because of the underscore and the capitals I thought those 
strings were something like placeholders.. And I did not see any reason for the 
commas, so I thought this might be a bug. Could've been that the jelly-bean 
notification center broke something.
Generally I don't mean to criticize, I try to help. I'm no native speaker, so 
I'm sorry if you got a different impression.

Original comment by 7amp...@gmail.com on 25 Aug 2012 at 7:42

GoogleCodeExporter commented 9 years ago
Ah, as for #3 that are the raw status strings from OpenVPN. It is probably 
better to map these to human readable strings.

For duplicate notification. The next version will add a FAQ entry why two 
notifcations are required. (See commit 39c9340da3c1)

Original comment by arne@rfc2549.org on 25 Aug 2012 at 8:14

GoogleCodeExporter commented 9 years ago
I looked into #1 and #2.

For #1: The google notification always uses the app icon for the notification.

#2: In Jelly Bean if I hide the notification icon by setting priority to 
PRIORITY_MIN the refreshing effect is visible. If I do not use PRIORITY_MIN the 
refreshing effect is gone but the notification is showing the refresh effect :

Original comment by arne@rfc2549.org on 27 Aug 2012 at 11:18

GoogleCodeExporter commented 9 years ago
I have watched other app and tried various alternatives of the source code. 
There seems to be no know of not having the refresh effect. Google play seems 
not suffer the effect but I have no idea what they do different.

Original comment by arne@rfc2549.org on 7 Sep 2012 at 1:40

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 562ae9f5f976.

Original comment by arne@rfc2549.org on 9 Sep 2012 at 11:22