lonnieezell / Bonfire

Jumpstart your CodeIgniter web applications with a modular, HMVC-ready, backend.
http://cibonfire.com
1.39k stars 524 forks source link

Countries & States #859

Open seant100 opened 11 years ago

seant100 commented 11 years ago

It appears the database tables may no longer used as the countries and states are in a config file. Can you please remove these from the installation process?

Also is it possible to rather have the country and states as an example of how to use / extend user profile with custom fields rather than including it the bonfire core installation. As it is now not all countries are catered for. Also some applications may already have databases that may want to make use of bonfire and hence already have countries/states tables.

xcript commented 11 years ago

And where are these config files?

EDIT: Found it in the address-Config. But why is it twice in the system? Are the tables or the config used? The migration files are still in the system.

xcript commented 11 years ago

Please remove the db tables for countries and states if they are not needed anymore.

mwhitneysdsu commented 11 years ago

If you need to remove these tables from the migrations, they're handled in 001, 002, and 006.

Maybe we should take a look at allowing a "clean installation" option that installs the database at a given migration number without going through the full steps (i.e. not creating the states and countries tables only to drop them). I'm not sure how difficult it would be to do this while maintaining a state that's consistent with running all of the migrations, but it would probably be a good idea to at least setup something every 10 migrations or so.

xcript commented 11 years ago

It's no problem for me to remove the tables, but they seem to be not used anymore in Bonfire. So they should be removed completely from the Bonfire base.