search

lonnieezell / Bonfire2

CodeIgniter 4-based application skeleton
MIT License
127 stars 49 forks source link

Introducing button and button-container components #434

Closed dgvirtual closed 4 months ago

dgvirtual commented 4 months ago

with example implementation in users module. If approved, I will change all instances of save button with this one.

I guess it might be a breaking change, since this component will be missing from admin theme for updaters. How do we handle that?

And, I am including the button component together with container providing alignment and spacing. Is that a good enough practice, or should it be two separate components? We only have one component with more than one button (widget settings page) and currently they are not side-by-side (though it could be easily done using htmx for the second button).

dgvirtual commented 4 months ago

OK, so I have separated the x-save-button component into two separate components: x-button-container and x-button. Also added optional attributes to x-button (type and color), defaulting to submit and primary (in the Bootstrap5 range).

daracorcoran commented 4 months ago

This might need to be documented for those updating - as in #449