search

lonnieezell / myth-auth

One-stop Auth package for CodeIgniter 4
MIT License
637 stars 208 forks source link

fix namespace entity ci 4.1.9 #514

Closed agiltriyas closed 2 years ago

agiltriyas commented 2 years ago

Namespace CodeIgniter/entity in ci version 4.1.9 is deprecated. change into codeIgniter/entity/entity

lonnieezell commented 2 years ago

I started to look at this one last night and one issue is that it now requires PHP 7.4 instead of 7.3, so the matrix needs to be updated - and something needs to be noted on minimum version changes.

lonnieezell commented 2 years ago

I wonder if we should revert this, get other stuff merged that needs to be, do a new release that still works for older versions of CI, and then do a new release right on the heels of that with this change and the updated PHP/CI version requirement?

MGatner commented 2 years ago

It's up to you. Our last release was July 2, 2021. Composer will handle version minimums, so we don't need a new major version to do a release for >= 7.4. Up to this point the dev dependency has been codeigniter4/codeigniter4 which means we have no idea if the develop branch for this package is still backwards-compatible to 4.1.9.

I am working on switching this to DevKit right now, which necessitates >= 7.4. We can always merge master up to right before this commit and put our a release, though honestly with workflows failing for the last many months I can't vouch for the state of any given commit.