lonnieezell / myth-auth

One-stop Auth package for CodeIgniter 4
MIT License
632 stars 207 forks source link

fix BaseFilter not found error after publishing filters from cli #571

Closed manageruz closed 1 year ago

manageruz commented 1 year ago

This will add 'use Myth\Auth\Filters\BaseFilter;' import to the all three filter files after publishing them by auth:publish command.

manageruz commented 1 year ago

Fixes #568

manageruz commented 1 year ago

Closes #569

manageruz commented 1 year ago

Waiting for review from @MGatner

manageruz commented 1 year ago

Here is still PHPStan and Rector errors. Extending BaseController instead of Controller will fix first one.

MGatner commented 1 year ago

Let's deal with the pipeline issues in a separate PR, then this will be much easier to pass and review. I can help with that later today, but it looks like you have a good start if you want to make a new branch and cherry-pick your commits.