search

lonnieezell / myth-auth

One-stop Auth package for CodeIgniter 4
MIT License
632 stars 207 forks source link

Deprecated Rector Class #586

Open mjamilasfihani opened 1 year ago

mjamilasfihani commented 1 year ago

https://github.com/lonnieezell/myth-auth/blob/da3522738a3076d579af3c060a65eefd8b800aba/rector.php#L32

from the comment : 

/**
 * @deprecated Moving doc types to type declarations is dangerous. Use specific strict types instead.
 * This rule will be split info many small ones.
 */

and I've check the devkit that it should change to Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector.

here is the commit history https://github.com/codeigniter4/devkit/commit/cf4df09b06fca93d89b1dfbe93b66ec4deef620a

mjamilasfihani commented 1 year ago

so many changes in devkit, should I rework all of them to? I mean, sync with the latest