search

lonsun / richmond_trees-admin

Richmond Trees Admin App
0 stars 0 forks source link

Make it so that you cannot save a duplicate address on an adoption request #30

Open lonsun opened 8 years ago

lizbittner commented 8 years ago

What about a situation where a home already has a tree that was planted last year, but they are requesting additional trees?

lonsun commented 8 years ago

Hi Liz,

I'm back! Currently, in that case you would pull up the existing adoption request and just add a tree. Does that work for you?

lizbittner commented 8 years ago

Okay, but I'm wondering how to get their request listed with the other requests that have not yet been met. Should I just unclick "completed", and add any appropriate notes? The one I'm thinking of now is 780 32nd. I decided to add a note because the tree care notes for the tree already at that address say that the tree is not being cared for (and turns out one of the trees died, so maybe he wants to replace that one?).

Also, in theory, there will be a different "received on" date, but I guess a date for a new request could go into the notes as well?

So now there are 3 adoption requests for this address for some reason. 2 say they are completed, but only one shows up when I look it up in the Plantings Report....wonder why that is? ID 1780 doesn't show up, but 1762 does. Maybe that's not a big deal, though....

On Tue, Aug 16, 2016 at 9:27 AM, Lon notifications@github.com wrote:

Hi Liz,

I'm back! Currently, in that case you would pull up the existing adoption request and just add a tree. Does that work for you?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lonsun/richmond_trees-admin/issues/30#issuecomment-240157255, or mute the thread https://github.com/notifications/unsubscribe-auth/ANYvhn-0zehEDGumFq7_h4eXm5vO7iOoks5qgeTZgaJpZM4HW7wE .

lonsun commented 8 years ago

All three show up if I use the adoption requests report and change the "completed" parameter to "both".

1901 2015-11-15 2 780 32nd false 1762 2 780 32nd true 1780 3 780 32nd Street true

This is the exact problem I'm trying to avoid. We have three entries for the exact same address and since plantings are associated with the adoption request and the address is part of the adoption request, we have three representations of the same location in the database. It will lead to a muddy data set...I think the correct way to fix this is to allow multiple adoption requests, but pull out the location/address to it's own entity. That way you can create as many adoption requests as you want, and the locations will be unambiguous. This will take a bit of work, but is the best way forward. I will start work on this in the next couple of days.

Until that is changed, we will have to rely on notes to keep track of what is happening. Let me know if you want to discuss anything else on this.

On Wed, Aug 17, 2016 at 8:15 PM, lizbittner notifications@github.com wrote:

Okay, but I'm wondering how to get their request listed with the other requests that have not yet been met. Should I just unclick "completed", and add any appropriate notes? The one I'm thinking of now is 780 32nd. I decided to add a note because the tree care notes for the tree already at that address say that the tree is not being cared for (and turns out one of the trees died, so maybe he wants to replace that one?).

Also, in theory, there will be a different "received on" date, but I guess a date for a new request could go into the notes as well?

So now there are 3 adoption requests for this address for some reason. 2 say they are completed, but only one shows up when I look it up in the Plantings Report....wonder why that is? ID 1780 doesn't show up, but 1762 does. Maybe that's not a big deal, though....

On Tue, Aug 16, 2016 at 9:27 AM, Lon notifications@github.com wrote:

Hi Liz,

I'm back! Currently, in that case you would pull up the existing adoption request and just add a tree. Does that work for you?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lonsun/richmond_trees-admin/issues/ 30#issuecomment-240157255, or mute the thread https://github.com/notifications/unsubscribe-auth/ANYvhn-0zehEDGumFq7_ h4eXm5vO7iOoks5qgeTZgaJpZM4HW7wE .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lonsun/richmond_trees-admin/issues/30#issuecomment-240613170, or mute the thread https://github.com/notifications/unsubscribe-auth/AHosxGH2xxBnwSr5C3z5EP7EaLU6JzuTks5qg85QgaJpZM4HW7wE .

SpotOn www.spoton.com Direct: (415) 306-9464

lizbittner commented 8 years ago

Okay, I think I see what you're saying. Sounds like you have a good plan. Thanks Lon

On Thu, Aug 18, 2016 at 8:54 AM, Lon notifications@github.com wrote:

All three show up if I use the adoption requests report and change the "completed" parameter to "both".

1901 2015-11-15 2 780 32nd false

1762 2 780 32nd true

1780 3 780 32nd Street true

This is the exact problem I'm trying to avoid. We have three entries for the exact same address and since plantings are associated with the adoption request and the address is part of the adoption request, we have three representations of the same location in the database. It will lead to a muddy data set...I think the correct way to fix this is to allow multiple adoption requests, but pull out the location/address to it's own entity. That way you can create as many adoption requests as you want, and the locations will be unambiguous. This will take a bit of work, but is the best way forward. I will start work on this in the next couple of days.

Until that is changed, we will have to rely on notes to keep track of what is happening. Let me know if you want to discuss anything else on this.

On Wed, Aug 17, 2016 at 8:15 PM, lizbittner notifications@github.com wrote:

Okay, but I'm wondering how to get their request listed with the other requests that have not yet been met. Should I just unclick "completed", and add any appropriate notes? The one I'm thinking of now is 780 32nd. I decided to add a note because the tree care notes for the tree already at that address say that the tree is not being cared for (and turns out one of the trees died, so maybe he wants to replace that one?).

Also, in theory, there will be a different "received on" date, but I guess a date for a new request could go into the notes as well?

So now there are 3 adoption requests for this address for some reason. 2 say they are completed, but only one shows up when I look it up in the Plantings Report....wonder why that is? ID 1780 doesn't show up, but 1762 does. Maybe that's not a big deal, though....

On Tue, Aug 16, 2016 at 9:27 AM, Lon notifications@github.com wrote:

Hi Liz,

I'm back! Currently, in that case you would pull up the existing adoption request and just add a tree. Does that work for you?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lonsun/richmond_trees-admin/issues/ 30#issuecomment-240157255, or mute the thread https://github.com/notifications/unsubscribe- auth/ANYvhn-0zehEDGumFq7_ h4eXm5vO7iOoks5qgeTZgaJpZM4HW7wE .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lonsun/richmond_trees-admin/issues/ 30#issuecomment-240613170, or mute the thread https://github.com/notifications/unsubscribe-auth/ AHosxGH2xxBnwSr5C3z5EP7EaLU6JzuTks5qg85QgaJpZM4HW7wE .

SpotOn www.spoton.com Direct: (415) 306-9464

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lonsun/richmond_trees-admin/issues/30#issuecomment-240768475, or mute the thread https://github.com/notifications/unsubscribe-auth/ANYvhqAUPeuxsrF8BvsU-vqhC8CF4I8Bks5qhIAagaJpZM4HW7wE .