search

looeee / discoverthreejs-site

Repo for the book Discover three.js!
https://discoverthreejs.com/
747 stars 98 forks source link

Translations for camera-controls and textures-intro files #85

Closed KevinZhang19870314 closed 2 years ago

KevinZhang19870314 commented 2 years ago

Now, I think all the files in first-steps folder are translated.

However, I found the home page is in a html file layouts\index.html, how to translate that?

KevinZhang19870314 commented 2 years ago

@looeee Hi, do we have a plan to release a new version with the chinese translations?

looeee commented 2 years ago

@KevinZhang19870314 did you finish the chapters? That's awesome, give me a couple of days to review and I will push the update live!

KevinZhang19870314 commented 2 years ago

@KevinZhang19870314 did you finish the chapters? That's awesome, give me a couple of days to review and I will push the update live!

Yes, now all the files in chapters first-steps and introduction are translated.

looeee commented 2 years ago

OK, that's great. Sorry for the slow reponses. Between typhoons and flooding and other projects it's been a busy month for me. I'll try to get this out in the next week.

I do also need to update the three.js version, currently we are on r136 which is a few releases behind. I'll do that sometime over the next few weeks. I'll keep changes to the text to a minimum but there's been some changes to color management that I should note. Can I ping you to update the Chinese text when that happens?

looeee commented 2 years ago

However, I found the home page is in a html file layouts\index.html, how to translate that?

The home page is a holdover from the old site (I originally wrote in in Django then ported to Hugo). This is why it's still a .html instead of .md, but because it's a very different design than other pages on the site it's a bit tricky to port over.

Let me think about the best way to handle the home page translation, I guess it will need a new language switcher button somewhere near the top as well. For now at least you can switch the language in the table of contents on that page.

looeee commented 2 years ago

Actually it was not too hard ^_^

I added the index.zh.html file plus a button to switch languages in the main nav.

I will switch this over to markdown another time. In the meantime, can you put the translations directly in index.zh.html?

KevinZhang19870314 commented 2 years ago

Actually it was not too hard ^_^

I added the index.zh.html file plus a button to switch languages in the main nav.

I will switch this over to markdown another time. In the meantime, can you put the translations directly in index.zh.html?

Sure, I'll translate it maybe earier last week.

KevinZhang19870314 commented 2 years ago

Can I ping you to update the Chinese text when that happens?

Sure.