loof2736 / scyfin

Custom theme for Jellyfin WebUI
GNU General Public License v3.0
213 stars 21 forks source link

A couple more UI elements that are off since 10.9.0 with 1.0.15 #14

Closed DrConflict closed 3 months ago

DrConflict commented 3 months ago

JMP 1.9.1 breaks the sidebar on Mac OS (seems JMP just needs to be updated for 10.9 though)

Screenshot 2024-05-12 at 10 01 56

webOS logo not fully visible yet

IMG_6747

In Brave (Chrome)

Screenshot 2024-05-12 at 09 55 11

Screenshot 2024-05-12 at 12 05 05

Thanks for fixing the previous issues so fast, much appreciated!

JamsRepos commented 3 months ago
  1. I've tried to replicate by installing JMP on my MacBook Air, I don't get custom server CSS on it, so not sure how you've managed to get that but I would assume your issue is most likely a cache one.
  2. Is this on an Apple TV?
  3. That too also might be cache, as this also loads perfectly fine for me.

Nevermind, I see you're using the optional extra addition of disabling the sidebar. I'll have a look at this tomorrow.

loof2736 commented 3 months ago

@DrConflict 1st and 3rd images should be fixed in 1.0.16 (Jellyfin Media Player sucks to develop CSS for). I wasn't able to replicate the 2nd picture, though I went ahead and added some slight padding to the logo which should prevent it from getting cut off

Let me know if the logo looks good with 1.0.16

DrConflict commented 3 months ago

Everything looking good with 1.0.17. I just discovered that the last image showing the overlap is caused by having my browser window "snapped" to the right side of my monitor. Once I give it full screen it looks fine, so I'm assuming this is an aspect ratio issue/bug.

IMG_6757 IMG_6758

DrConflict commented 3 months ago
  1. I've tried to replicate by installing JMP on my MacBook Air, I don't get custom server CSS on it, so not sure how you've managed to get that but I would assume your issue is most likely a cache one.
  2. Is this on an Apple TV?
  3. That too also might be cache, as this also loads perfectly fine for me.

Nevermind, I see you're using the optional extra addition of disabling the sidebar. I'll have a look at this tomorrow.

  1. Yeah it seems to have been a caching issue, I ran JF in a private window again and all is good now
  2. No, it's JF client 1.2.2 running on webOS
  3. Is fixed as well now as of 1.0.17. Everything looking crisp and clean

Thanks for the quick fixes guys!

JamsRepos commented 3 months ago

Huh odd, well glad you two have managed to fix the majority. I replace the image on my server so I didn't really see this happening on mine.

DrConflict commented 3 months ago

Wdym with you "replaced the image on your server"? I have setup a fresh new server for the 10.9 release, but I'm guessing some stuff was still cached in my browser. JMP hasn't been updated so browser is the only real option atm.

JamsRepos commented 3 months ago

Wdym with you "replaced the image on your server"? I have setup a fresh new server for the 10.9 release, but I'm guessing some stuff was still cached in my browser. JMP hasn't been updated so browser is the only real option atm.

I replace the standard images with my own so I might have slightly different clipping to what you have. I also do not have the menu collapsed.

/* Change Logo */

/* Main Drawer Mobile Logo*/
.adminDrawerLogo img { content: url('https://imagehere.com') !important; }
/* Login Page Logo*/
.imgLogoIcon { content: url('https://imagehere.com') !important; }
/* Home Page Logo */
.pageTitleWithLogo { background-image: url('https://imagehere.com') !important; }

EDIT: Also note, there's currently issues with JMP. https://github.com/jellyfin/jellyfin/issues/11623#issuecomment-2109347426

DrConflict commented 3 months ago

Ah right, gotcha! And yeah JMP hasn't updated for 10.9 yet so there are issues. You can force it to use the "externalwebclient" in the client settings though

loof2736 commented 3 months ago

Are you still having the same misalignment issue when the browser is snapped to either side? I haven't been able to replicate the issue.

DrConflict commented 3 months ago

Everything seems to look right now when snapped to sides. I think you can close this one.