search

loof2736 / scyfin

Custom theme for Jellyfin WebUI
GNU General Public License v3.0
213 stars 21 forks source link

Why is the desktop app code separate? #2

Closed robocrax closed 1 year ago

robocrax commented 1 year ago

This is an amazing theme.

I'm just curious why you haven't merged the Jellyfin Media Player desktop app CSS code with the main code.

What are the effects of just putting this code on the server instead of the individual client apps?

I added the line to my server instead of individual clients as there were too many but noticed no difference on the web and the theme still looks good.

Any reason why you've decided to keep it separate?

loof2736 commented 1 year ago

The only reason that I don't have it in the main code is because it messes with the positioning of the Quick Connect page in Settings. Not really a big deal I suppose, but I just decided to keep it separate. There might be a way to fix it and merge it with the main code, I'll have to look at it

loof2736 commented 1 year ago

I figured out a kind of hacky way to get it to work without looking too weird, and I went ahead and merged it in v1.0.8