loof2736 / scyfin

Custom theme for Jellyfin WebUI
GNU General Public License v3.0
259 stars 28 forks source link

Snow theme player slider wrong color on Chrome #38

Closed Nicolas-Gth closed 2 months ago

Nicolas-Gth commented 2 months ago

It seems that you forgot to replace the colors in the playback-video.css file. image

My fix for chrome (but the shape is still not the same as Firefox and I would be better to use the --accent variable rather than hardcoding the color hex).

.mdl-slider::-webkit-slider-thumb {
              background: #fff;
}

image

I saw many other classes with the hard coded blue color that I think should be replaced with the --accent variable

.countIndicator, .fullSyncIndicator, .mediaSourceIndicator, .playedIndicator {
    background: #fff;
}

for example

loof2736 commented 2 months ago

This seems to be a bug with some new version of Jellyfin not handling the CSS correctly if they have both Webkit and Firefox specific selectors in the same CSS block. I'll see if I can find which version this originated in and open a bug report on the main Jellyfin github repo.

CSS like this works in Firefox, but not Chrome:

.mdl-slider::-moz-range-thumb, .mdl-slider::-webkit-slider-thumb { background: blue !important; }

For Chrome, it has to be formatted like this for some reason:

.mdl-slider::-moz-range-thumb { background: blue !important; } .mdl-slider::-webkit-slider-thumb { background: blue !important; }

loof2736 commented 2 months ago

Actually this doesn't seem to be an issue with Jellyfin, rather CSS in general. I could have sworn this was working before, but I must have moved some stuff around in the CSS and never tested it in Chrome.

Basically Chrome doesn't recognize certain Firefox specific CSS selectors (and vice versa, I just haven't run into any in Firefox). When this happens, Chrome just throws out the entire CSS block they are present in.

I just need to separate a couple selectors, should be a simple fix

loof2736 commented 2 months ago

Fixed in v1.4.8