loogart / Project-Mountain

Summits accreditation user interface re-skin with a modified Canada.ca theme.
https://loogart.github.io/Project-Mountain/
0 stars 0 forks source link

Country codes #3

Open T-Diego opened 6 years ago

T-Diego commented 6 years ago

Should be in a +XX format, not 001, etc...

For example: Canada number: +1 (613) 555-8989 Mexico Number: +52 (area code) 555-5565

etc

https://en.wikipedia.org/wiki/List_of_country_calling_codes

loogart commented 6 years ago

@T-Diego some countries have 3 numbers.

T-Diego commented 6 years ago

So?

From: Chris Soueidan [mailto:notifications@github.com] Sent: October-31-17 10:30 AM To: loogart/Project-Mountain Cc: Tremblay, Diego -DSMD; Mention Subject: Re: [loogart/Project-Mountain] Country codes (#3)

@T-Diegohttps://github.com/t-diego some countries have 3 numbers.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/loogart/Project-Mountain/issues/3#issuecomment-340779926, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfYbWEhAXwPaKIr5o01QVMLnL2Q7Vo3Hks5sxy7ugaJpZM4P94T4.

loogart commented 6 years ago

Oh you're just saying to change the placeholder to XX instead of numerals?

T-Diego commented 6 years ago

https://gist.github.com/andyj/7108917

From: Chris Soueidan [mailto:notifications@github.com] Sent: October-31-17 11:25 AM To: loogart/Project-Mountain Cc: Tremblay, Diego -DSMD; Mention Subject: Re: [loogart/Project-Mountain] Country codes (#3)

Oh you're just saying to change the placeholder to XX instead of numerals?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/loogart/Project-Mountain/issues/3#issuecomment-340797976, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfYbWOu6PBJSYAEBkSN0p5yMyHtjwNzhks5sxzu2gaJpZM4P94T4.

loogart commented 6 years ago

@T-Diego fixed, I implemented a country code picker AND phone number formatting based on the country.

https://loogart.github.io/Project-Mountain/registration-step4.html

screen shot 2017-10-31 at 3 09 16 pm

T-Diego commented 6 years ago

Good improvement, but not quite what I wanted. I do realize that maybe I mislead you, so come see me and I’ll show you what I mean.

D

From: Chris Soueidan [mailto:notifications@github.com] Sent: October-31-17 3:09 PM To: loogart/Project-Mountain Cc: Tremblay, Diego -DSMD; Mention Subject: Re: [loogart/Project-Mountain] Country codes (#3)

@T-Diegohttps://github.com/t-diego fixed, I implemented a country code picker AND phone number formatting based on the country.

https://loogart.github.io/Project-Mountain/registration-step4.html

[screen shot 2017-10-31 at 3 09 16 pm]https://user-images.githubusercontent.com/7881400/32243988-7bf119ac-be4d-11e7-8ee0-1c3ce0c25ca2.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/loogart/Project-Mountain/issues/3#issuecomment-340875433, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfYbWJZCZL930V6vByIPqtqU2VDYzRi9ks5sx3BngaJpZM4P94T4.

loogart commented 6 years ago

Replace country 2-letter code with actual country name. If flag or additional info can be added, bonus, but not necessary.