search

loogart / impact-canada

Canadian Government's Privy Council's Office Impact Canada website.
https://loogart.github.io/impact-canada/
0 stars 0 forks source link

Fix container positioning and width #16

Closed loogart closed 5 years ago

loogart commented 5 years ago

Note that the width of the container is wider than the About and how it works pages (which require .narrow css class). I guess I would like to have the ability to toggle the css class as a template for wider vs. narrow content. Let me know if this makes sense to you!

djsutter commented 5 years ago

This will take some template work. Not sure if we can allow customize, but probably need to base the narrow with on "basic page"

djsutter commented 5 years ago

This is done by setting max width on <main> for basic page. Unfortunately it ruins the Challenges page so will have to find a way around that. Might have to make a new content type such as "Basic Page Narrow" or maybe "Static Page". Ideas?

loogart commented 5 years ago

that's a good idea. We can have two templates: (1) basic page (regular .container) and (2) narrow basic page (.container .narrow). Would that work? (and would you rather I consolidate this with issue #24?

loogart commented 5 years ago

one thing i did notice, the challenges page (which we will remove anyways), has been affected.

screen shot 2018-12-08 at 6 57 38 pm
djsutter commented 5 years ago

Fixed!! Added a checkbox to Basic Page to indicate rendering in a narrow column. I set this flag on the About page (only). image

loogart commented 5 years ago

@djsutter OMG I am so excited for this. I had a tear of joy when I saw this graceful implementation you setup!!! 🎁