search

loogart / impact-canada

Canadian Government's Privy Council's Office Impact Canada website.
https://loogart.github.io/impact-canada/
0 stars 0 forks source link

Navigation bar (highlight color tabindex) #27

Closed loogart closed 5 years ago

loogart commented 5 years ago

Just noticed this, when using tab to navigate with the accessibility feature, the background color of the highlighted navigation item is light gray. We should remove this bg color and simply keep the usual blue rectangular halo around the selected item.

screen shot 2018-12-07 at 10 01 47 am
djsutter commented 5 years ago

I've seen it and I think it might be fixed now by dumb luck. Probably from the scss consolidation that I just did.

loogart commented 5 years ago

hey duncan! still seeing it on Chrome Version 70.0.3538.110 (Official Build) (64-bit).

djsutter commented 5 years ago

Can you try a full refresh (probably CTRL-F5) or a cache clear? I tried it on exact same version of Chrome and it's ok for me. Or I'm missing something.

loogart commented 5 years ago

@djsutter still tried (with hard refresh), it's showing up on Chrome. I will try at work tomorrow as well just in case.

djsutter commented 5 years ago

Assuming you know how to inspect elements with your browser, you can always find the offending css code and let me know what it is. It's probably coming from wetkit, but I'll need to know the path of css entities so I can override it.

loogart commented 5 years ago

Yes! here is the offending css within theme.min.css

http://impact.qualivera.com/libraries/theme-gcweb/css/theme.min.css?pjho27

.nav>li>a:focus, .nav>li>a:hover { text-decoration: none; background-color: #eee; }

djsutter commented 5 years ago

Ok check now, I think we got it!