loogart / impact-canada

Canadian Government's Privy Council's Office Impact Canada website.
https://loogart.github.io/impact-canada/
0 stars 0 forks source link

Ability to rename Summary/description tab #44

Closed loogart closed 5 years ago

loogart commented 5 years ago

Hey Duncan, we would need to be able to edit/add the Summary/description TITLE of this section which shows up as the first tab on the challenge page.

Example:

screen shot 2018-12-19 at 2 44 18 pm screen shot 2018-12-19 at 2 42 18 pm
djsutter commented 5 years ago

Do you mean rename "The Challenge" as shown above?

loogart commented 5 years ago

yes. Need to add a title for the description/summary box. (just like challenge subpages have a title which appear on the challenge navigation tabs! Thanks!

djsutter commented 5 years ago

Ok have a look at the challenge pages now and see if they're working as wanted. The changes are temporary so if it's ok then I will make them permanent in the source code. Then I can look at how to give you control to rename "Home" to whatever you like.

loogart commented 5 years ago

Awesome. thank you for the insanly quick turnaround! I noticed something I might try to fix from my end on the css (the flexbox implementation for the challenge nav looks less interesting for 2 tabs, see image below) - ill create another issue for myself and which might require a new css gulp.

screen shot 2018-12-19 at 3 35 46 pm
djsutter commented 5 years ago

Roger that!

djsutter commented 5 years ago

Ok this is done. The field is called "Nav Title" and it's mandatory. Of course, existing challenge pages don't have a value. The default is "Home" (Accueil). Currently I have set the Nav title for the Crush It challenge to be "Main page" (english only). Since it's a mandatory field, I will leave as-is and let you fix it.

loogart commented 5 years ago

that is #boss. AWESOME! thank you.