search

loogart / impact-canada

Canadian Government's Privy Council's Office Impact Canada website.
https://loogart.github.io/impact-canada/
0 stars 0 forks source link

Accessibility checkup #53

Closed loogart closed 5 years ago

loogart commented 5 years ago
loogart commented 5 years ago

@djsutter hey Duncan, can we fix the accessibility issues based off this report? there are multiple broken skip links and broken ARIA references. There seems to be a double for skip to main content and skip to about this site and the skip to language toggle is broken.

screen shot 2019-01-15 at 7 33 25 am

Here are sample reports from the WAVE tool online. This applies to all main pages and challenge pages.

Main pages http://wave.webaim.org/report#/https://impact.canada.ca/en http://wave.webaim.org/report#/https://impact.canada.ca/en/about http://wave.webaim.org/report#/https://impact.canada.ca/en/how-it-works https://impact.canada.ca/en/news https://impact.canada.ca/en/partner-with-us

Challenge page example http://wave.webaim.org/report#/https://impact.canada.ca/en/challenges/crush-it

djsutter commented 5 years ago

I fixed the skip links on the impact.qualivera site but you might want to have a look to see if it's what you're expecting. I found that the WxT theme includes a built-in method to set the top two links from the GUI, and the 3 links which follow were provided by the template files. I have deleted those. So what remains is the first two links to main content and language toggle. If it looks good, I can apply part of the fix to the live site right away. Then we can look at the other issues being reported.

loogart commented 5 years ago

@djsutter works like a charm. The only link i would keep is the Skip to "About this site like in the prototype https://loogart.github.io/impact-canada/#wb-info (which brings the user to the footer.

Then we can tackle each page and the broken ARIA references?

djsutter commented 5 years ago

Hopefully all the errors are fixed now. Since the WxT theme only allows for two links, and you want three, I had to delete theirs from the template and go back to the three links which probably came from your template. Had to fix a number of #wb-cont ids which needed to be #wb-content.

djsutter commented 5 years ago

BTW you can test with links like this http://wave.webaim.org/report#/http://impact.qualivera.com/en

loogart commented 5 years ago

awesome! #nailedIt thank you!