search

loogart / impact-canada

Canadian Government's Privy Council's Office Impact Canada website.
https://loogart.github.io/impact-canada/
0 stars 0 forks source link

Challenge subpage titles #67

Closed loogart closed 5 years ago

loogart commented 5 years ago

@djsutter this is a minor semantic issue, but probably easy to fix and can be done whenever. Can we make all challenge subpage titles h2 (instead of h1) since the Challenge title in the "jumbotron" area is already an h1?

E.g. https://impact.canada.ca/en/challenges/off-diesel/initiative (title is highlighted)

screen shot 2019-02-07 at 3 04 55 pm

djsutter commented 5 years ago

This is done on the dev site impact.qualivera.com Note that the bottom margin for h2 in this context is larger than the previous h1

loogart commented 5 years ago

That is no problem (thanks for pointing it out), somedays I feel my ui needs more spacing, somedays, i feel it needs less. I just feel better (in my gut) that the structure of headings is good.

You can push this to the live site!

djsutter commented 5 years ago

Ok done!