search

lookbook-hq / lookbook

A UI development environment for Ruby on Rails apps ✨
https://lookbook.build
MIT License
889 stars 91 forks source link

add safe guard for headers["X-Frame-Options"].upcase #561

Closed adrienpoly closed 10 months ago

adrienpoly commented 10 months ago

since upgrading to 2.20 I had an error coming from the preview controller

see for details https://github.com/ViewComponent/lookbook/issues/549#issuecomment-1829469384

netlify[bot] commented 10 months ago

Deploy Preview for lookbook-docs ready!

Name Link
Latest commit 1d403de6fadf11ef3ec0c27640a9bd35be2e7873
Latest deploy log https://app.netlify.com/sites/lookbook-docs/deploys/6565f60908509b0008a7e70c
Deploy Preview https://deploy-preview-561--lookbook-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Spone commented 10 months ago

Thanks @adrienpoly for the fix!

matiasleidemer commented 8 months ago

It would be great to release this fix to RubyGems 😇

allmarkedup commented 8 months ago

@matiasleidemer Thanks for the reminder! I had completely forgotten I hadn't published a new release with this in 🙄

I've just pushed up v2.2.1 that includes this fix. Sorry for any inconvenience :)