search

lookbook-hq / lookbook

A UI development environment for Ruby on Rails apps ✨
https://lookbook.build
MIT License
889 stars 91 forks source link

Allow disabling of error handling #582

Closed wheeyls closed 8 months ago

wheeyls commented 8 months ago

Per issue #528 Allow opting out of catching errors in the application controller. Allows usage of web_console, better_errors, and other solutions.

netlify[bot] commented 8 months ago

Deploy Preview for lookbook-docs canceled.

Name Link
Latest commit b8a2be5f788a6c0c16ec5d049bd80abd8470964b
Latest deploy log https://app.netlify.com/sites/lookbook-docs/deploys/65b59bf3ac5ed00008a96265
allmarkedup commented 8 months ago

Hey @wheeyls, thank you for this!

In a future major release of Lookbook it may be that not handling errors becomes the default behaviour as I've never been super happy with it. But having it as a config option for now is great.

I'll just give it a try now but if I don't find any issues with it I'll merge it in, add a note in the docs and get it out in the next release. Thanks again :)

allmarkedup commented 8 months ago

Looks good, merging now - thanks again for the contribution!

wheeyls commented 8 months ago

Thanks @allmarkedup.And yeah I agree as a rule I'd prefer the default behavior is to let me choose my error handling strategy myself, there are lots of other solutions out there.