search

lookbook-hq / lookbook

A UI development environment for Ruby on Rails apps ✨
https://lookbook.build
MIT License
889 stars 91 forks source link

SVG not render in latest Chrome on Mac #625

Closed michael-yin closed 3 months ago

michael-yin commented 3 months ago

Describe the bug

In the latest Chrome 126.0.6478.56 on Mac, the svg do not render correctly

Screenshots

If I visit https://demo.lookbook.build/lookbook

svg-issue

How to fix

lucide-sprite.svg need to be updated

According to https://oliverjam.es/articles/svg-sprites, I changed to <svg xmlns="http://www.w3.org/2000/svg"> and the issue has been fixed.

Spone commented 3 months ago

Hi @michael-yin thanks for reporting this! Would you like to open a PR to apply your fix?

michael-yin commented 3 months ago

Hi, @Spone

I have created a PR to fix the issue, please check it.

Thx.

allmarkedup commented 3 months ago

@michael-yin thank youI PR is merged now and I'll get a new release out later today :)