looker-open-source / components

Looker's UI Components, Design Infrastructure and more
https://components.looker.com
MIT License
62 stars 31 forks source link

fix(Dialog): Animation delay on open #2878

Closed mdodgelooker closed 3 years ago

mdodgelooker commented 3 years ago

Previously, DialogSurface, DrawerSurface, and Backlog were using CSS transition to animate in and out. The problem with this is that the transition starts when the className changes from 'entering' to 'entered' which is 300ms after the click to open. The dialog renders immediately on click, then sits hidden for 300ms before animating in.

We want the animation to begin immediately on render, so we have to use CSS animation instead. PanelSurface was already doing this.

github-actions[bot] commented 3 years ago

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟒 Statements 94.84% 7303/7700
🟑 Branches 87.16% 4651/5336
🟒 Functions 93.63% 2102/2245
🟒 Lines 95.38% 7067/7409

Status of coverage: 🟒 - ok, 🟑 - slightly more than threshold, πŸ”΄ - under the threshold

Report generated by πŸ§ͺjest coverage report action from 029acbd84f13087d625d2e1a3aecb12a9877bd08