search

looker-open-source / components

Looker's UI Components, Design Infrastructure and more
https://components.looker.com
MIT License
62 stars 31 forks source link

Button component sizing issue #2921

Closed kufelkamil closed 2 years ago

kufelkamil commented 3 years ago

Starting from version 2.8.7 Button component behaves unexpectedly, it shrinks too much when used inside Space along with other components. Maybe the bug was introduced in 2.8.6 as a part of adding ripple effect (according to the changelog), but I cannot choose 2.8.6 on codesandbox.

https://codesandbox.io/s/beautiful-hill-oxs3f?file=/src/index.tsx

obraz obraz

Workaround is to wrap Button in div, like 

<Space>
    <div><Button iconBefore={<Pivot />}>Add something</Button></div>
    ...
</Space>
kufelkamil commented 2 years ago

Hi, in version 2.8.13 issue still exists, any chance to fix it?

mdodgelooker commented 2 years ago

Hi @kufelkamil thank you for raising this issue, and apologies for the delay. We're working on a fix now.

mdodgelooker commented 2 years ago

Hi @kufelkamil this issue is fixed in v2.8.14: https://codesandbox.io/s/admiring-smoke-ge5kw