looker-open-source / components

Looker's UI Components, Design Infrastructure and more
https://components.looker.com
MIT License
62 stars 31 forks source link

Potential changes to Query #2933

Closed mdodgelooker closed 2 years ago

mdodgelooker commented 2 years ago

Exploring a possible way to avoid duplicate calls to get query metadata in the Vis/Filter Demo app.

(There's currently a bug with this approach where if you try to re-submit the original query ID after filtering it, you still just get the filtered one.)

github-actions[bot] commented 2 years ago

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟑 Statements 90.04% 8257/9170
πŸ”΄ Branches 80.45% 5000/6215
🟑 Functions 88.44% 2272/2569
🟑 Lines 90.52% 7988/8825

Status of coverage: 🟒 - ok, 🟑 - slightly more than threshold, πŸ”΄ - under the threshold

Show files with reduced coverage πŸ”» ### Reduced coverage | Status | Filename | Statements | Branches | Functions | Lines | | :----: | :------------------------------------------ | :--------- | :------- | :-------- | :----- | | πŸ”΄ | visualizations-adapters/src/Query/Query.tsx | 3.41% | 0% | 0% | 3.61% | > Status of coverage: 🟒 - ok, 🟑 - slightly more than threshold, πŸ”΄ - under the threshold

Report generated by πŸ§ͺjest coverage report action from 78db77d8d2c8ed0758267f7a9cd7dbebcabe1c17

mdodgelooker commented 2 years ago

Thanks for taking a look @dbchristopher, I love your ideas! Let's discuss in the components app dev sync this afternoon.

mdodgelooker commented 2 years ago

No longer needed.