search

looker-open-source / embed-sdk

The Looker browser embedding SDK
MIT License
70 stars 45 forks source link

Support for hiding multiple filters via the EmbedBuilder? #151

Open blaizeb-at-x opened 1 year ago

blaizeb-at-x commented 1 year ago

I'd like to fix values and hide a few filters in a dashboard I'm attempting to embed into a single page app. I can confirm that if I manually produce a URI with something like filter1=value1&filter2=value2&hide_filter=filter1&hide_filter=filter2 I get the desired result. However, I'm struggling to do this via the EmbedBuilderdue to the fact that the _params: UrlParams type doesn't allow repeat keys or an interable value that could be mapped to the necessary multiple hide_filter url param key value pairs.

Is there another suggested way for adding multiple hidden filters? If not, I'd be happy to submit a PR attempting to add such functionality.

yovrer commented 1 year ago

I have the same issue

nuwen commented 1 year ago

Would love this to be implemented

eino commented 7 months ago

Hello @bryans99, I have opened PR #177 to implement this feature, could you please check if the implementation looks good to you?