search

looker-open-source / embed-sdk

The Looker browser embedding SDK
MIT License
72 stars 47 forks source link

feat: extend withParams so it works also with list #179

Closed brunouber closed 8 months ago

brunouber commented 8 months ago

With this PR we allow withParams to accept Record<string, string | string[]>, instead of just Record<string, string>.

.withParams({ key: ["foo", "bar"] })

It also updates the private stringify function to handle this case nicely, eg. &key=foo&key=bar.

This functionality is useful so that also SDK's user are allowed to hide dashboard filters (doc).

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

brunouber commented 8 months ago

Just noticed there's another PR addressing the same issue.