search

looker-open-source / henry

A command line tool for Looker instance cleanup
MIT License
79 stars 27 forks source link

Bump or remove upper Python version constraint? #53

Closed daniel-ferguson closed 1 year ago

daniel-ferguson commented 2 years ago

Hi, I ran into this issue https://github.com/looker-open-source/henry/issues/47 due to using a more modern Python version (3.10). 3.7 isn't EOL yet (but will be on 27 Jun 2023) but can be have issues on OS's with fully up to date packages.

Is there a plan for bumping the max version supported at some point in the future? Or perhaps even to remove the upper constraint entirely to avoid having to keep it up to date with Python releases (optimistically hoping new releases don't break this package)?

tpakeman commented 2 years ago

54 pending review.

For context, the previous version of the looker_sdk used by Henry was tied to a specific python version. The newer sdk versions have no such constraint.

As a result, this PR makes henry require a looker_sdk version >= 22 and a python version >= 3.6, but should allow for less brittle forward compatibility

daniel-ferguson commented 1 year ago

Ah, that's great - thank you. Closing now since #54 has been merged