looker-open-source / henry

A command line tool for Looker instance cleanup
MIT License
79 stars 27 forks source link

Fix Pulse and update Henry to work with recent Looker system_activity model changes #57

Open JorickvdHoeven opened 1 year ago

JorickvdHoeven commented 1 year ago

Problem Statement

Henry has been having two large issues making it difficult to use:

  1. The Pulse command is failing because of an issue in the Looker SDK with the try_connection command.
  2. The queries were running against the i__looker explore which seems to be getting deprecated or seems to be inaccessible to users who aren't admins.

These two problems impact Henry's ability to run and make it difficult to use. We need to fix these so that people can continue to use Henry to administer their Looker instances.

Proposed solution

  1. Pulse command not working:

    • Given that the reason why the pulse command isn't working is because of the deprecation of the ilooker explore and the fact that the sdk try_connection is broken, we need to catch the exception generated by the sdk and update the queries to use the system_activity explore instead of the ilooker explore.
  2. Analyze queries not working:

    • ilooker is an explore that is either deprecated or limited to admins, given that generally not all users are admins we should update to use the system_activity explore and update the fields that are used so that we can leverage this explore. An added benefit is that the system_activity explore (on a sample of 1 instance) runs much faster than ilooker.
google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.