search

looker-open-source / henry

A command line tool for Looker instance cleanup
MIT License
79 stars 27 forks source link

Modernize henry - fixes all current bugs and switches to non-deprecated system__activity #85

Closed rbob86 closed 2 months ago

rbob86 commented 2 months ago

Fixes crash due to outdated object reference https://github.com/looker-open-source/henry/issues/82

Fixes crash due to invalid field reference in call to run_inline_query in get_used_models() https://github.com/looker-open-source/henry/issues/86

Fixes invalid filter error due to i__looker losing workspace_id filter https://github.com/looker-open-source/henry/issues/83

Adds looker__internal_analytics__replica to reserved_names in check_db_connection

Incorporates changes from https://github.com/looker-open-source/henry/pull/57 to use system__activity instead of i__looker, which is deprecated.

jeremytchang commented 2 months ago

Can you confirm that you've verified this fixes the issue? Also can you link the issue in the PR description?

rbob86 commented 2 months ago

Can you confirm that you've verified this fixes the issue? Also can you link the issue in the PR description?

This resolves the issue (see first output of python -m henry.cli --help without change, second with the change:

image
ice-ctrl commented 2 months ago

Please merge this update. It resolves one of the issues at least.