Library Fails to Import on Windows

looker-open-source / henry

A command line tool for Looker instance cleanup

MIT License

79 stars 27 forks source link

Library Fails to Import on Windows #9

Closed coolbreezechloe closed 4 years ago

coolbreezechloe commented 4 years ago

On a windows machine where the Users folder is in use the \U in the path C:\Users... is misinterpreted as a unicode escape sequence. This happens because the default value being passed to the logging module args parameter is not properly escaped. Probably not noticed on linux or mac because the do not use a backslash. I have provided a fix in pull request #7.

josephaxisa commented 4 years ago

Hi @coolbreezechloe, noted, thank you! I have spent some time refactoring henry and in the new version this is no longer an issue. I will be publishing a release relatively soon, but in the meantime if you want to try the new version please feel free to checkout the henry-v020 branch.

josephaxisa commented 4 years ago

@coolbreezechloe the new version (v0.2.0) just published was successfully tested on Windows and this should be solved. Let me know if you run into problems.