search

looker-open-source / look-at-me-sideways

A style guide and linter for Looker's LookML data modeling language
MIT License
126 stars 37 forks source link

Opt-in rules specified in manifest.lkml not being recognized (v3) #141

Closed rushikaverma-aiq closed 1 year ago

rushikaverma-aiq commented 1 year ago

I'm trying to implement LAMS v3 and for some reason the opt-in rules as specified in the read.me just aren't getting picked up during the run.

screenshot of the manifest.lkml file:

Screen Shot 2023-08-03 at 5 07 42 PM

command line args used:

Screen Shot 2023-08-03 at 5 14 23 PM

screenshot of the run:

Screen Shot 2023-08-03 at 5 02 44 PM

Thanks!

rushikaverma-aiq commented 1 year ago

I was getting the following 3 moderate severity vulnerabilities warning so after updating the code, getting a different error. I'm wondering if these vulnerabilities are causing the opt-in rules to not be invoked? Attached below is a screenshot of the code and the error msg

code:

Screen Shot 2023-08-04 at 4 11 19 PM

error:

Screen Shot 2023-08-04 at 4 12 11 PM
fabio-looker commented 1 year ago

From your first screenshot, I see LAMS is saying "No manifest.lkml file available", so that explains why no rules are being opted in to at that stage. Are you running the command from the root of your LookML repo (and/or using the cwd argument to specify a correct working directory?)

I'll look into the dependencies that NPM is warning about and release a patch update for them, however this is not a blocking issue.

The blocking issue seems to be some NPM issue related to /workdir/.DS_Store file permssions, however I am not familiar with what NPM is trying to do here...

I see you are trying to run some NPM package-lock related commands. Could you elaborate why you need these? Since the LAMS package is installed globally with the -g flag, I think the subsequent install command probably doesn't do something helpful. Is there an issue with the way I am shipping LAMS' dependencies that you are trying to work around?

fabio-looker commented 1 year ago

Also, it seems all 3 of the dependencies with issues are dev dependencies. These are pruned from the npm-shrinkwrap.json file before it is published to NPM, so you should not be seeing this issue when doing npm install -g @looker/look-at-me-sideways@3. I just tried that myself and did not see any warnings/vulnerabilities:

image