looker-open-source / looker-explore-assistant

A React Application for interacting with Looker data through natural language.
MIT License
101 stars 68 forks source link

fix(assistantState): cache full state when reloading assistant #39

Closed waziers closed 4 months ago

waziers commented 4 months ago
google-cla[bot] commented 4 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gtricerriv commented 4 months ago

Changes are only a proof of concept, for context the nested useCallback in the assistant UI is being cached before all data is received on hard page reload (redux state wipe). I tried adding a wrapper that waits till everything is fetched but it seems transpiled code is still generating a submit handler whose actual dependencies are incomplete at the time of caching.

I will update it based on any feedback so that it adheres to the contributing guidelines.