looker-open-source / looker-explore-assistant

A React Application for interacting with Looker data through natural language.
MIT License
83 stars 52 forks source link

dynamic fields and filter expression with "=" inside the value break #50

Closed pjabl closed 2 months ago

pjabl commented 2 months ago

explore-assistant-extension bug src\components\ExploreEmbed.tsx

exploreUrl
        .split('&')
        .map((param) => (paramsObj[param.split('=')[0]] = param.split('=')[1]))

cause cropping of dynamic_field or filter_expression in looker url after the first "=" , which corrupt the expression, example:

{
    "category": "table_calculation",
    "expression": "${order.total_product_amount} >=${percentile} AND ${order.total_product_amount} <=${percentile_1}"
}
LukaFontanilla commented 2 months ago

https://github.com/looker-open-source/looker-explore-assistant/pull/51