search

looker-open-source / sdk-codegen

One SDK to rule them all, and in the codegen bind them
MIT License
232 stars 195 forks source link

`python-sdk-tutorial.ipynb` shows outdated comments #1397

Closed giuliosmall closed 2 months ago

giuliosmall commented 12 months ago

When initialising Looker SKD with Python, the example on Google Collab shows:

Now that we've set all the necessary environment variables, we should be able to initialize the Looker SDK. When initializing the SDK, you choose which version to use— 3.1 or 4.0. The 4.0 SDK has some new endpoints and bug fixes, but is still experimental.

While the official documentation:

Note: As of Looker 22.4, the [Looker API 4.0 is generally available](https://cloud.google.com/looker/docs/api-4-ga). In Looker 23.18, the [Looker API 3.1 has been removed](https://cloud.google.com/looker/docs/api-3x-deprecation).
jeremytchang commented 2 months ago

Fixed here: https://github.com/looker-open-source/sdk-codegen/blob/main/python/python-sdk-tutorial.ipynb?short_path=97a9c9f#L165C1-L166C1