search

looker-open-source / sdk-codegen

One SDK to rule them all, and in the codegen bind them
MIT License
232 stars 195 forks source link

@looker/extension-sdk requires react #1438

Closed AndrewKoliaka closed 1 week ago

AndrewKoliaka commented 8 months ago

We use Looker in Angular project. And when I try to upgrade @looker/extension-sdk from 23.6.0 to the latest version 24.2.0 it breaks with the error:

ERROR in node_modules/@looker/extension-sdk/lib/connect/tile/types.d.ts:1:33 - error TS2307: Cannot find module 'react' or its corresponding type declarations.

1 import type { MouseEvent } from 'react';
drstrangelooker commented 1 week ago

@bryans99 Is this resolved by https://github.com/looker-open-source/sdk-codegen/pull/1532?

jkaster commented 1 week ago

This should be resolved by #1532