search

looker / custom_visualizations_v2

MIT License
93 stars 157 forks source link

Subtotal Visualization Feedback #22

Closed emma-ware closed 6 years ago

emma-ware commented 6 years ago

Issue Summary

Options to edit visualization are occasionally missing (not on every explore load). Re-running query causes edit options to appear. Reloading the page causes the edit options to disappear again.

Link/Screenshots Of Issue:

screen shot 2018-06-06 at 9 45 45 am

Features Affected: Visualizations

Issue Info

Steps:

  1. Go to any explore in Meta
  2. Create a Subtotal visualization
  3. Check the visualization edit options a. If there are options, refresh the page until they disappear b. If the options are missing, re-run the query and they will disappear

Error Message: No errors in the JS console

Customer Info

Client: metanew Version: 5.17.00000628-231040 URL: https://meta.looker.com/explore/bq_salesforce/zendesk_tickets?qid=7e36dgnbE9JKaAaLCc1DW3&toggle=dat,fil,vis,vse Development Mode: No User: Emma Ware

emma-ware commented 6 years ago

Issue Summary

Hidden measures still show in visualization, table calculations do not show in visualization

Link/Screenshots Of Issue: screen shot 2018-06-06 at 10 28 29 am

Issue Info

Steps:

  1. Go to any Explore in Meta
  2. Add dimensions, measures, and a table calculation
  3. Hiding measures has no effect, table calcs do not show in visualization

Error Message: No errors in the JS console

RichardCzechowski commented 6 years ago

Thanks @emma-ware the first issue is a global issue with all custom vis right now. But the latter are definitely things we should address. cc @statico

emma-ware commented 6 years ago

Thanks @RichardCzechowski ! Got another one with hiding dimensions:

Issue Summary

Hiding dimension causes the sort order to reverse, but the dimension remains in the visualization. Hiding all dimensions prompts the Not Enough Dimensions This visualization requires at least 1 dimension. message.

Link/Screenshots Of Issue:

hiding dimensions

Error Message: No errors in JS console

emma-ware commented 6 years ago

General feedback:

When scrolling, the header of the column (with the dimension name) scrolls as well and is not visible when you scroll down the rows. In our table visualization, the header of the column stays fixed to the top of the columns, making it clear what fields you are viewing when further down in the table.

scroll header

statico commented 6 years ago

Thanks for finding these.

  1. Missing vis options — as @RichardCzechowski pointed out, this is a bug with Looker and is tracked there AFAIK
  2. Hidden columns still shown — I'll address this today or tomorrow
  3. Hidden dimensions — Will fix, see above
  4. Sticky header — This is a non-trivial enhancement (~2-5 hours) and I think we punted on it. Cc'ing @wynnandrewj for a decision.
wynnandrewj commented 6 years ago

Thanks @emma-ware for filing.

2 and 3 look good. 4 we did decide to punt on for now but will wait for customer feedback and see if its a worthwhile enhancement.

statico commented 6 years ago

I went to go and fix the bugs with columns not being hidden, but it appears that the hidden status of any column is not passed through to the custom vis plugin. Here's a diff of two dimensions, one that has been hidden and one that hasn't. Both have hidden set to false. This looks like a Looker bug, unfortunately.

untitled

RichardCzechowski commented 6 years ago

@statico the hiddenness of a field is not a property of the visconfig, it is a property of the query response. As a result, fields do not show up in the 'fields' property of a queryResponse if they are hidden, even though they show up in the data.