search

looker / custom_visualizations_v2

MIT License
93 stars 157 forks source link

iFrame sandbox options #47

Open svickers opened 5 years ago

svickers commented 5 years ago

With custom visualizations being sandboxed via the sandbox iframe attribute, is there any hope of letting this be configurable? Adding allow-same-origin and/or allow-top-navigation would make interactions with the vizs much more powerful. AFAIK The way it currently is we can't even make use of Links on dimensions like the out of the box visualizations can.

drinkzima commented 5 years ago

Would love to chat with you about types of use cases you are thinking about here. We're considering a more open version of this but want to understand the needs a little better. Are you coming to JOIN next week? (otherwise can you shoot me a note to colin@looker.com)

svickers commented 5 years ago

Yup I will be there next week, happy to meet up.

nickfogler commented 5 years ago

I'd be interested in joining this conversation, too!  (I'm at the 4 Mile booth)

On Thu, Oct 4, 2018 12:38 PM, Scott Vickers notifications@github.com wrote: Yup I will be there next week, happy to meet up.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

svickers commented 5 years ago

Upon further investigation it looks like we could potentially be using LookerCharts.Utils.openUrl() but it throws an exception deep inside the looker js:

main-05bd04281f6c9f2ff1fe.chunk.js:50 Uncaught TypeError: Cannot read property 'metaKey' of null
    at Function.e.openUrl (main-05bd04281f6c9f2ff1fe.chunk.js:50)
    at Function.value (main-05bd04281f6c9f2ff1fe.chunk.js:1)
    at e.<anonymous> (main-05bd04281f6c9f2ff1fe.chunk.js:50)
    at main-05bd04281f6c9f2ff1fe.chunk.js:1
    at r (main-05bd04281f6c9f2ff1fe.chunk.js:14)
tispratik commented 5 years ago

This will be helpful. I have a case wherein i need to access the filters in the dashboard from the custom visualization so that i can update the custom visualization based on the filter changes in the dashboard.