looker / looker-sdk-ruby

Looker SDK for Ruby
Other
39 stars 43 forks source link

api key and secret should be sent via body, not query string #87

Closed yingbiao closed 4 years ago

yingbiao commented 4 years ago

Looks like Ruby SDK is sending api key and secret via querystring, it should be sent via body instead. We used gzr(https://github.com/looker-open-source/gzr) to import dashboard which is using this sdk underlying, and we are seeing the secret being logged in our firewall logs, and server logs. Basically, anyone who looks at this request (MITM style) can see our auth credentials without having to ssl decrypt the request.

yingbiao commented 4 years ago

https://github.com/looker/looker-sdk-ruby/blob/master/lib/looker-sdk/authentication.rb#L54