search

looker / lookerbot

Lookerbot lets you access all your Looker data from Slack! Super fun!
https://looker.com/lookerbot
MIT License
170 stars 141 forks source link

Lookerbot broken for Slack Enterprise users #184

Closed tomdev closed 4 years ago

tomdev commented 4 years ago

Slack Enterprise users with multiple teams cannot use Lookerbot when the enableSharedWorkspaces configuration option is not enabled, while this should be the case when the user is part of the same workspace as the lookerbot user.

Cause of this problem is the Slack API not returning the "team_id" attribute for enterprise users.

Regular Slack users API response

https://api.slack.com/methods/users.info

Typical success response:

{
  "id": "W012A3CDE",
  "team_id": "T012AB3C4",
  "name": "spengler",

Enterprise Slack user API response

The following data is pulled from the lookerbot by logging the user object returned from the Slack API when an Enterprise user is requesting a lookerbot command:

{
  id: 'WR_USER_ID',
  [...]
  enterprise_user: {
    id: 'WR_USER_ID',
    enterprise_id: 'EQ_ENTERPRISE_ID',
    enterprise_name: 'EnterpriseName',
    is_admin: false,
    is_owner: false,
    teams: [ 'T00000001', 'T00000002' ]
  },
  enterprise_id: 'EQ_ENTERPRISE_ID',
  teams: [ 'T00000001', 'T00000002' ],
  enterprise_name: 'EnterpriseName'
}

Todo

Workspace membership validation https://github.com/looker/lookerbot/blob/master/src/services/slack_service.ts#L183 should also check on the user.teams to confirm a user is or is not part of the same workspace as the lookerbot user.