search

lookfirst / sardine

an easy to use webdav client for java
Other
579 stars 185 forks source link

Close Unmarshaller after using it #259

Closed jochenberger closed 8 years ago

jochenberger commented 8 years ago

Prevent memory leak by checking if the Unmarshaller is Closeable and closing it if it is (see also https://java.net/jira/browse/JAXB-1000).

jochenberger commented 7 years ago

Do you plan to release a new version anytime soon? Those leaks are causing trouble in one of my applications.

jochenberger commented 7 years ago

@dkocher, any news here?

dkocher commented 7 years ago

@jochenberger This has been merged into master on 26 Oct 2016. @lookfirst Do you want to make an official release build?

lookfirst commented 7 years ago

@dkocher Sure... but I can't remember how... been so long... what's the instructions again? Happy if you want to do it too. =)

dkocher commented 7 years ago

@lookfirst I could do it if I revert the build back to Maven. Not familiar with the Travis build you introduced.

lookfirst commented 7 years ago

@dkocher Hi David... the travis build is separate from the release process. Travis just runs maven... https://github.com/lookfirst/sardine/blob/master/.travis.yml

dkocher commented 7 years ago

@lookfirst Sorry, I was mixing things up.

lookfirst commented 7 years ago

I just remembered, I documented it in the UG.

https://github.com/lookfirst/sardine/wiki/UsageGuide#maven

But I bet that I'm the only one who can publish to maven due to security stuff, so that is no good. If you want to somehow take that over or co-own that, I'm more than happy to give up control there.

lookfirst commented 7 years ago

It is a pain because I have to log into maven central to actually publish it. Never did figure out a way to make that automatic.

dkocher commented 7 years ago

We can add the nexus-staging-maven-plugin to publish to https://oss.sonatype.org/.

dkocher commented 7 years ago

I see that I already have permission for staging com.github.lookfirst. I will look into this then.

lookfirst commented 7 years ago

Whatever works best for you man. =) I'm all for it.

jochenberger commented 7 years ago

I usually publish my projects to bintray/jCenter. I let Travis build and deploy the tagged commits via Gradle. Works like a charm. I think you can setup a sync to Maven Central too.

lookfirst commented 7 years ago

Whatever you guys like to do as long as it is simple and easy to understand. =) Automating it would be awesome.

jochenberger commented 7 years ago

See https://docs.travis-ci.com/user/deployment. I use the "script" deployment provider, see for example https://github.com/eddyson-de/tapestry-react/blob/master/.travis.yml#L17.

jochenberger commented 7 years ago

If I can do something to help (as long as it's not with Maven), just let me know.