Update to Apache HttpClient v5

lookfirst / sardine

an easy to use webdav client for java

Other

573 stars 184 forks source link

Update to Apache HttpClient v5 #333

Open hakanai opened 3 years ago

hakanai commented 3 years ago

For external reasons we would like to update to Apache HttpClient v5.x, but currently Sardine has a hard dependency on v4.x, which forces us to keep around two implementations of all our HTTP code.

It would be nice if Sardine updated to v5.x also.

lookfirst commented 3 years ago

Sure. PR welcome.

hakanai commented 3 years ago

I've figured out how to do most of it. Where I'm currently stuck:

DefaultRedirectStrategy is very different to before. isRedirectable is gone, as is getRedirect
HttpClientContext.TARGET_AUTH_STATE and AuthState itself are both gone
RequestAcceptEncoding and ResponseContentEncoding are both gone

Partial work: https://github.com/hakanai/sardine/tree/apache-http5

ivarmont commented 11 months ago

I would like to take over this issue, as no update has been given in the last 2 years, would that be ok?

tprus commented 5 months ago

dkocher commented 4 months ago

I would like to take over this issue, as no update has been given in the last 2 years, would that be ok?

Pull requests are definitely welcome.

PetrusHahol commented 1 month ago

Any updates here? I think it would be great to have http/2 support, but its only achivable by having HttpClient 5