search

lookit / ember-lookit-frameplayer

Ember app with experiment frames and a frame player to run browser-based experiments
MIT License
5 stars 20 forks source link

console warning about video consent template "consent_005" #325

Open becky-gilbert opened 1 year ago

becky-gilbert commented 1 year ago

Describe the bug

The video consent frame shows a warning when consent template 005 is used.

Which frame or frames does it affect?

exp-lookit-video-consent

To Reproduce

  1. Create a study that uses a video consent frame and consent_005 as the template:
"video-consent": {
  "kind": "exp-lookit-video-consent",
  "template": "consent_005"
},
  1. Click 'preview' from the study edit page.
  2. When the study reaches the consent frame, observe that the following warning is shown in the console:

    Invalid consent form specified. 'template' parameter of 'exp-lookit-video-consent' frame should be one of: consent_001 consent_002 consent_003 consent_004

Expected behavior

I don't think this should produce a warning. I assume what happened is that someone just forgot to update this list of valid templates when they added consent template 5:

https://github.com/lookit/ember-lookit-frameplayer/blob/cef88879d7df16cd565a64fc159ab176556a8e9d/app/components/exp-lookit-video-consent/component.js#L372