lookit / ember-lookit-frameplayer

Ember app with experiment frames and a frame player to run browser-based experiments
MIT License
5 stars 20 forks source link

Fix/309 ajv compile frame schema error #328

Closed Vantoine2019 closed 1 week ago

Vantoine2019 commented 1 year ago

This PR addresses the issue #309 by

Expected behavior

Additional information

Depending on your preferences, it would also be possible to separate the console.log into two separate messages e.g.

catch (error) {
    console.group('ajv compile error');
    console.error(`Failed to compile frameSchemaProperties to use for validating researcher usage of frame type '${this.get('kind')}'.`);
    console.error(`Compile error message='${error.message}'`);
    console.groupEnd();
}
becky-gilbert commented 1 year ago

@Vantoine2019 thanks so much for this contribution! ❤️ Looks great, and thanks for adding the error details to the console message. I'm happy with just adding it all to the same message, as you've already done here.

I'll tag CJ and Melissa for reviews.

becky-gilbert commented 1 year ago

@mekline I'm adding this to the current shape with the idea that it can be added to the next EFP release (in which we do away with Pipe).