search

lookit / ember-lookit-frameplayer

Ember app with experiment frames and a frame player to run browser-based experiments
MIT License
5 stars 19 forks source link

Responses with survey-consent should be marked as having consent #352

Closed becky-gilbert closed 9 months ago

becky-gilbert commented 9 months ago

This fixes a problem the data not being available to researchers for studies using the survey-consent frame. The problem is happening because responses with survey-consent are not marked has having a consent frame (completed_consent_frame is always false), which means that the response session does not appear in the 'consent ruling' area and therefore is never available via the data download pages.

This PR fixes part of issue https://github.com/lookit/lookit-api/issues/1317 in that it makes responses with survey-consent available to the researcher via the consent ruling area.

However it does not close the issue because we still need to flag these responses has having consent via survey (so that the researcher can be sure to check the consent response when accessing the data).

mekline commented 9 months ago

Can you share a bit more about the process the researcher will go through with these sessions? Maybe screenshots of what they see in the Consent Manager at different states?

becky-gilbert commented 9 months ago

Can you share a bit more about the process the researcher will go through with these sessions? Maybe screenshots of what they see in the Consent Manager at different states?

I know we talked about this already, but just to clarify: all this PR does is make the survey-consent responses available via the consent ruling page. It doesn't flag these responses in the UI.

I'm setting up the response flagging through separate PRs in the lookit-api and here in EFP (issue here: https://github.com/lookit/lookit-api/issues/1317). I've also opened an issue in lookit-docs for adding some information to the docs about handling data with survey-consent: https://github.com/lookit/lookit-docs/issues/372.

I put this small change in its own PR so that, if we want to make survey-consent responses available to researchers ASAP, we can merge this now and add the response-flagging and docs later. Or we can wait and publish all of these changes together.