search

lookit / lookit-api

Codebase for Lookit v2 and Experimenter v2. Includes an API. Docs: http://lookit.readthedocs.io/
https://lookit.mit.edu/
MIT License
10 stars 18 forks source link

Fixed issue with js errors not showing in ui. #1318

Closed okaycj closed 9 months ago

okaycj commented 9 months ago

There's a bug in production where the breadcrumbs aren't being displayed. This validation was using the breadcrumbs element as a reference to place the JS errors on the EFP runner edit form. This removes the need for the breadcrumbs reference.

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

okaycj commented 9 months ago

As I mentioned in #1312 I would still like to fix the breadcrumb errors, but at least now the two things are separate and we can get this validation error fix in production ASAP!

@becky-gilbert I put up a PR to fix the breadcrumb issue.