Closed becky-gilbert closed 5 months ago
Thanks for reviewing @ianchandlercampbell and @bleonar5!
If you can put a few notes in a Translations section in the handbook as you finish this, that would be helpful!
Already done ✅
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Fixes #1373
This PR does the following:
Parameterizes the contact information in this case:
so that the
contact
text is passed into the translation string as an argument. Now the translation is written as:This allows the translator to move the 'contact' text to a different part of the sentence, which is a requirement for the Hungarian translation.
"Este estudio es realizado por"
is now"Este estudio es realizado por %(contact)s."
Developer workflow notes
Updating all of the .po files on
develop
andmaster
should not cause problems for the site. Translations of the site will be missing some translations regardless of whether or not we update these files - when this happens, the English text is used. And having the most up-to-date versions on ourdevelop
branch should make it easier for outside contributors and translators to grab the most recent .po files, check for missing translations, and submit their updates via PRs. But I'm open to other suggestions if anyone sees a problem with this workflow.